mirror of
https://github.com/Shopify/liquid.git
synced 2026-09-26 13:45:13 -07:00
render end of string is not optional
This commit is contained in:
committed by
Guilherme Carreiro
parent
5ec3008b37
commit
5660ce6945
@@ -111,6 +111,8 @@ module Liquid
|
|||||||
@attributes[key] = safe_parse_expression(p)
|
@attributes[key] = safe_parse_expression(p)
|
||||||
p.consume?(:comma) # optional comma
|
p.consume?(:comma) # optional comma
|
||||||
end
|
end
|
||||||
|
|
||||||
|
p.consume(:end_of_string)
|
||||||
end
|
end
|
||||||
|
|
||||||
def strict_parse(markup)
|
def strict_parse(markup)
|
||||||
|
|||||||
@@ -113,6 +113,8 @@ module Liquid
|
|||||||
@attributes[key] = safe_parse_expression(p)
|
@attributes[key] = safe_parse_expression(p)
|
||||||
p.consume?(:comma) # optional comma
|
p.consume?(:comma) # optional comma
|
||||||
end
|
end
|
||||||
|
|
||||||
|
p.consume(:end_of_string)
|
||||||
end
|
end
|
||||||
|
|
||||||
def rigid_template_name(p)
|
def rigid_template_name(p)
|
||||||
|
|||||||
@@ -220,6 +220,10 @@ class IncludeTagTest < Minitest::Test
|
|||||||
'{% include "snippet" !!! arg1: "value1" ~~~ arg2: "value2" %}',
|
'{% include "snippet" !!! arg1: "value1" ~~~ arg2: "value2" %}',
|
||||||
error_mode: mode,
|
error_mode: mode,
|
||||||
)
|
)
|
||||||
|
assert_syntax_error(
|
||||||
|
'{% include "snippet" | filter %}',
|
||||||
|
error_mode: mode,
|
||||||
|
)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
@@ -121,6 +121,10 @@ class RenderTagTest < Minitest::Test
|
|||||||
'{% render "snippet" !!! arg1: "value1" ~~~ arg2: "value2" %}',
|
'{% render "snippet" !!! arg1: "value1" ~~~ arg2: "value2" %}',
|
||||||
error_mode: mode,
|
error_mode: mode,
|
||||||
)
|
)
|
||||||
|
assert_syntax_error(
|
||||||
|
'{% render "snippet" | filter %}',
|
||||||
|
error_mode: mode,
|
||||||
|
)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user