Rubocop fixes (#1182)

test/unit/strainer_unit_test.rb

@@ -20,8 +20,8 @@ class StrainerUnitTest < Minitest::Test
 
   def test_strainer
     strainer = Strainer.create(nil)
-    assert_equal 5, strainer.invoke('size', 'input')
-    assert_equal "public", strainer.invoke("public_filter")
+    assert_equal(5, strainer.invoke('size', 'input'))
+    assert_equal("public", strainer.invoke("public_filter"))
   end
 
   def test_stainer_raises_argument_error
@@ -40,45 +40,45 @@ class StrainerUnitTest < Minitest::Test
         /\ALiquid error: wrong number of arguments \((1 for 0|given 1, expected 0)\)\z/,
         e.message
       )
-      assert_equal e.backtrace[0].split(':')[0], __FILE__
+      assert_equal(e.backtrace[0].split(':')[0], __FILE__)
     end
   end
 
   def test_strainer_only_invokes_public_filter_methods
     strainer = Strainer.create(nil)
-    assert_equal false, strainer.class.invokable?('__test__')
-    assert_equal false, strainer.class.invokable?('test')
-    assert_equal false, strainer.class.invokable?('instance_eval')
-    assert_equal false, strainer.class.invokable?('__send__')
-    assert_equal true, strainer.class.invokable?('size') # from the standard lib
+    assert_equal(false, strainer.class.invokable?('__test__'))
+    assert_equal(false, strainer.class.invokable?('test'))
+    assert_equal(false, strainer.class.invokable?('instance_eval'))
+    assert_equal(false, strainer.class.invokable?('__send__'))
+    assert_equal(true, strainer.class.invokable?('size')) # from the standard lib
   end
 
   def test_strainer_returns_nil_if_no_filter_method_found
     strainer = Strainer.create(nil)
-    assert_nil strainer.invoke("private_filter")
-    assert_nil strainer.invoke("undef_the_filter")
+    assert_nil(strainer.invoke("private_filter"))
+    assert_nil(strainer.invoke("undef_the_filter"))
   end
 
   def test_strainer_returns_first_argument_if_no_method_and_arguments_given
     strainer = Strainer.create(nil)
-    assert_equal "password", strainer.invoke("undef_the_method", "password")
+    assert_equal("password", strainer.invoke("undef_the_method", "password"))
   end
 
   def test_strainer_only_allows_methods_defined_in_filters
     strainer = Strainer.create(nil)
-    assert_equal "1 + 1", strainer.invoke("instance_eval", "1 + 1")
-    assert_equal "puts",  strainer.invoke("__send__", "puts", "Hi Mom")
-    assert_equal "has_method?", strainer.invoke("invoke", "has_method?", "invoke")
+    assert_equal("1 + 1", strainer.invoke("instance_eval", "1 + 1"))
+    assert_equal("puts",  strainer.invoke("__send__", "puts", "Hi Mom"))
+    assert_equal("has_method?", strainer.invoke("invoke", "has_method?", "invoke"))
   end
 
   def test_strainer_uses_a_class_cache_to_avoid_method_cache_invalidation
     a = Module.new
     b = Module.new
     strainer = Strainer.create(nil, [a, b])
-    assert_kind_of Strainer, strainer
-    assert_kind_of a, strainer
-    assert_kind_of b, strainer
-    assert_kind_of Liquid::StandardFilters, strainer
+    assert_kind_of(Strainer, strainer)
+    assert_kind_of(a, strainer)
+    assert_kind_of(b, strainer)
+    assert_kind_of(Liquid::StandardFilters, strainer)
   end
 
   def test_add_filter_when_wrong_filter_class
@@ -105,7 +105,7 @@ class StrainerUnitTest < Minitest::Test
     error = assert_raises(Liquid::MethodOverrideError) do
       strainer.class.add_filter(PrivateMethodOverrideFilter)
     end
-    assert_equal 'Liquid error: Filter overrides registered public methods as non public: public_filter', error.message
+    assert_equal('Liquid error: Filter overrides registered public methods as non public: public_filter', error.message)
   end
 
   module ProtectedMethodOverrideFilter
@@ -122,7 +122,7 @@ class StrainerUnitTest < Minitest::Test
     error = assert_raises(Liquid::MethodOverrideError) do
       strainer.class.add_filter(ProtectedMethodOverrideFilter)
     end
-    assert_equal 'Liquid error: Filter overrides registered public methods as non public: public_filter', error.message
+    assert_equal('Liquid error: Filter overrides registered public methods as non public: public_filter', error.message)
   end
 
   module PublicMethodOverrideFilter
@@ -134,7 +134,7 @@ class StrainerUnitTest < Minitest::Test
   def test_add_filter_does_not_raise_when_module_overrides_previously_registered_method
     strainer = Context.new.strainer
     strainer.class.add_filter(PublicMethodOverrideFilter)
-    assert strainer.class.filter_methods.include?('public_filter')
+    assert(strainer.class.filter_methods.include?('public_filter'))
   end
 
   module LateAddedFilter
@@ -144,9 +144,9 @@ class StrainerUnitTest < Minitest::Test
   end
 
   def test_global_filter_clears_cache
-    assert_equal 'input', Strainer.create(nil).invoke('late_added_filter', 'input')
+    assert_equal('input', Strainer.create(nil).invoke('late_added_filter', 'input'))
     Strainer.global_filter(LateAddedFilter)
-    assert_equal 'filtered', Strainer.create(nil).invoke('late_added_filter', 'input')
+    assert_equal('filtered', Strainer.create(nil).invoke('late_added_filter', 'input'))
   end
 
   def test_add_filter_does_not_include_already_included_module
@@ -162,6 +162,6 @@ class StrainerUnitTest < Minitest::Test
     strainer = Context.new.strainer
     strainer.class.add_filter(mod)
     strainer.class.add_filter(mod)
-    assert_equal 1, mod.include_count
+    assert_equal(1, mod.include_count)
   end
 end # StrainerTest