Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-16 17:30:43 -07:00
Code Issues Packages Projects Releases Wiki Activity

don't allow invalid syntax inside comment tag

Browse Source
This commit is contained in:
Michael Go
2023-12-14 17:01:03 -04:00
parent c658bf970a
commit 3c5ad7db61
2 changed files with 34 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/unit/tags/comment_tag_unit_test.rb
+32 -12
View File
@@ -31,25 +31,45 @@ class CommentTagUnitTest < Minitest::Test
LIQUID
end
def test_allows_incomplete_tags_inside_a_comment
assert_template_result("", <<~LIQUID.chomp)
def test_allows_unclosed_tags
assert_template_result('', <<~LIQUID.chomp)
{% comment %}
{% assign foo = "1"
{% if true %}
{% endcomment %}
LIQUID
end
def test_block_body_must_be_valid
assert_template_result('', <<~LIQUID.chomp)
{% comment %}
{% assign a = 123 {% comment %}
{% endcomment %}
LIQUID
assert_template_result("", <<~LIQUID.chomp)
{% comment %}
assert_raises(Liquid::SyntaxError) do
assert_template_result("", <<~LIQUID.chomp)
{% comment %}
{% invalid
{% assign foo = "1"
{% endcomment %}
{% endcomment %}
LIQUID
LIQUID
end
assert_template_result("", <<~LIQUID.chomp)
{% comment %}
{% {{ {%- endcomment %}
LIQUID
assert_raises(Liquid::SyntaxError) do
assert_template_result("", <<~LIQUID.chomp)
{% comment %}
{% comment %}
{% invalid
{% endcomment %}
{% endcomment %}
LIQUID
end
assert_raises(Liquid::SyntaxError) do
assert_template_result("", <<~LIQUID.chomp)
{% comment %}
{% {{ {%- endcomment %}
LIQUID
end
end
def test_child_comment_tags_need_to_be_closed