From e5dd63e1fcc952f48bb2a25cb8a953d79704edc7 Mon Sep 17 00:00:00 2001 From: Justin Li Date: Mon, 20 Apr 2015 17:36:04 -0400 Subject: [PATCH 1/2] Expose name, lookups, and command flags from VariableLookup --- lib/liquid/variable_lookup.rb | 2 ++ test/unit/variable_unit_test.rb | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/lib/liquid/variable_lookup.rb b/lib/liquid/variable_lookup.rb index 6a58fe22..38423ee8 100644 --- a/lib/liquid/variable_lookup.rb +++ b/lib/liquid/variable_lookup.rb @@ -3,6 +3,8 @@ module Liquid SQUARE_BRACKETED = /\A\[(.*)\]\z/m COMMAND_METHODS = ['size'.freeze, 'first'.freeze, 'last'.freeze] + attr_reader :name, :lookups, :command_flags + def self.parse(markup) new(markup) end diff --git a/test/unit/variable_unit_test.rb b/test/unit/variable_unit_test.rb index 084b846a..36d43233 100644 --- a/test/unit/variable_unit_test.rb +++ b/test/unit/variable_unit_test.rb @@ -147,4 +147,16 @@ class VariableUnitTest < Minitest::Test var = Variable.new(%! name_of_variable | upcase !) assert_equal " name_of_variable | upcase ", var.raw end + + def test_variable_lookup_interface + lookup = VariableLookup.new('a.b.c') + assert_equal 'a', lookup.name + assert_equal ['b', 'c'], lookup.lookups + assert_equal 0, lookup.command_flags + + lookup = VariableLookup.new('a.first.size') + assert_equal 'a', lookup.name + assert_equal ['first', 'size'], lookup.lookups + assert_equal 0b11, lookup.command_flags + end end From f1f3f576478068df18a7d28c59f7db8d30dd97f5 Mon Sep 17 00:00:00 2001 From: Justin Li Date: Tue, 21 Apr 2015 00:25:51 -0400 Subject: [PATCH 2/2] Remove command_lookups reader --- lib/liquid/variable_lookup.rb | 2 +- test/unit/variable_unit_test.rb | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/liquid/variable_lookup.rb b/lib/liquid/variable_lookup.rb index 38423ee8..92f57c83 100644 --- a/lib/liquid/variable_lookup.rb +++ b/lib/liquid/variable_lookup.rb @@ -3,7 +3,7 @@ module Liquid SQUARE_BRACKETED = /\A\[(.*)\]\z/m COMMAND_METHODS = ['size'.freeze, 'first'.freeze, 'last'.freeze] - attr_reader :name, :lookups, :command_flags + attr_reader :name, :lookups def self.parse(markup) new(markup) diff --git a/test/unit/variable_unit_test.rb b/test/unit/variable_unit_test.rb index 36d43233..d175af2f 100644 --- a/test/unit/variable_unit_test.rb +++ b/test/unit/variable_unit_test.rb @@ -152,11 +152,5 @@ class VariableUnitTest < Minitest::Test lookup = VariableLookup.new('a.b.c') assert_equal 'a', lookup.name assert_equal ['b', 'c'], lookup.lookups - assert_equal 0, lookup.command_flags - - lookup = VariableLookup.new('a.first.size') - assert_equal 'a', lookup.name - assert_equal ['first', 'size'], lookup.lookups - assert_equal 0b11, lookup.command_flags end end