mirror of
https://github.com/Shopify/liquid.git
synced 2026-10-03 00:55:11 -07:00
Fix rubocop offenses
This commit is contained in:
@@ -153,7 +153,7 @@ module Liquid
|
|||||||
if name.start_with?("end")
|
if name.start_with?("end")
|
||||||
base = name.byteslice(3, name.bytesize - 3)
|
base = name.byteslice(3, name.bytesize - 3)
|
||||||
stack = open_stacks[base]
|
stack = open_stacks[base]
|
||||||
if stack.length > 0
|
unless stack.empty?
|
||||||
open_pos = stack.pop
|
open_pos = stack.pop
|
||||||
@has_matching_end_tag[open_pos] = true
|
@has_matching_end_tag[open_pos] = true
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -151,7 +151,6 @@ Benchmark.ips do |x|
|
|||||||
x.config(time: 10, warmup: 5)
|
x.config(time: 10, warmup: 5)
|
||||||
|
|
||||||
TEMPLATES.each do |label, source|
|
TEMPLATES.each do |label, source|
|
||||||
begin
|
|
||||||
Liquid::Template.parse(source, environment: env)
|
Liquid::Template.parse(source, environment: env)
|
||||||
x.report("parse: #{label}") do
|
x.report("parse: #{label}") do
|
||||||
Liquid::Template.parse(source, environment: env)
|
Liquid::Template.parse(source, environment: env)
|
||||||
@@ -159,7 +158,6 @@ Benchmark.ips do |x|
|
|||||||
rescue Liquid::SyntaxError => e
|
rescue Liquid::SyntaxError => e
|
||||||
puts " Skipping '#{label}' - #{e.message}"
|
puts " Skipping '#{label}' - #{e.message}"
|
||||||
end
|
end
|
||||||
end
|
|
||||||
|
|
||||||
x.compare!
|
x.compare!
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -108,7 +108,7 @@ class TokenizerTest < Minitest::Test
|
|||||||
|
|
||||||
def test_matching_end_tag_handles_nested_same_name_tags
|
def test_matching_end_tag_handles_nested_same_name_tags
|
||||||
tokenizer = new_tokenizer(
|
tokenizer = new_tokenizer(
|
||||||
'{% render "a" %}{% render "b" %}inner{% endrender %}outer{% endrender %}'
|
'{% render "a" %}{% render "b" %}inner{% endrender %}outer{% endrender %}',
|
||||||
)
|
)
|
||||||
tokenizer.send(:shift) # {% render "a" %}
|
tokenizer.send(:shift) # {% render "a" %}
|
||||||
# Should find the outer endrender (depth-aware), not the inner one
|
# Should find the outer endrender (depth-aware), not the inner one
|
||||||
@@ -126,7 +126,7 @@ class TokenizerTest < Minitest::Test
|
|||||||
def test_matching_end_tag_returns_false_when_only_nested_end_tag
|
def test_matching_end_tag_returns_false_when_only_nested_end_tag
|
||||||
# Only a nested endrender exists (consumed by the inner render), no outer endrender
|
# Only a nested endrender exists (consumed by the inner render), no outer endrender
|
||||||
tokenizer = new_tokenizer(
|
tokenizer = new_tokenizer(
|
||||||
'{% render "a" %}{% render "b" %}{% endrender %}'
|
'{% render "a" %}{% render "b" %}{% endrender %}',
|
||||||
)
|
)
|
||||||
tokenizer.send(:shift) # {% render "a" %}
|
tokenizer.send(:shift) # {% render "a" %}
|
||||||
# The endrender belongs to the inner render (depth 1 -> 0), not the outer (depth 0)
|
# The endrender belongs to the inner render (depth 1 -> 0), not the outer (depth 0)
|
||||||
|
|||||||
Reference in New Issue
Block a user