Update inline snippets syntax

Previously, inline snippets syntax looked a bit
different, they:

- used strings as tag identifiers
- defined tag arguments {% snippet "input" |type| %}

This PR updates snippets to better reflect
the currently proposed syntax

Co-authored-by: Orlando Qiu <[email protected]>

lib/liquid/tags/render.rb

@@ -54,15 +54,15 @@ module Liquid
       # Inline snippets take precedence over external snippets
       if (inline_snippet = context.registers[:inline_snippet][template_name])
         inner_context = context.new_isolated_subcontext
-
         snippet_body = inline_snippet[:body]
-        snippet_args = inline_snippet[:args]
-        # Validate and set the arguments in the inner context
-        @attributes.each do |key, value|
-          unless snippet_args.include?(key)
-            raise Liquid::ArgumentError, "Invalid argument `#{key}` for snippet `#{template_name}`"
-          end
 
+        context.scopes.each do |scope|
+          scope.each do |key, value|
+            inner_context[key] = value
+          end
+        end
+
+        @attributes.each do |key, value|
           inner_context[key] = context.evaluate(value)
         end
 

lib/liquid/tags/snippet.rb

@@ -1,28 +1,25 @@
 # frozen_string_literal: true
 
 module Liquid
-  # @liquid_public_docs
   # @liquid_type tag
   # @liquid_category theme
   # @liquid_name snippet
   # @liquid_summary
-  #   Creates a new inline snippet using a string value as the identifier.
+  #   Creates a new inline snippet.
   # @liquid_description
   #   You can create inline snippets to make your Liquid code more modular.
   # @liquid_syntax
-  #   {% snippet "input" %}
+  #   {% snippet input %}
   #     value
   #   {% endsnippet %}
+
   class Snippet < Block
-    SYNTAX = /(#{QuotedString})(?:\s*\|\s*([\w\s,]+)\s*\|)?/o
+    SYNTAX = /(#{VariableSignature}+)/o
+
     def initialize(tag_name, markup, options)
       super
-
       if markup =~ SYNTAX
         @to = Regexp.last_match(1)
-        args = Regexp.last_match(2)
-
-        @args = args ? args.split(/\s*,\s*/) : []
       else
         raise SyntaxError, options[:locale].t("errors.syntax.snippet")
       end
@@ -30,22 +27,10 @@ module Liquid
 
     def render(context)
       context.registers[:inline_snippet] ||= {}
-      context.registers[:inline_snippet][snippet_id] = {
-        body: snippet_body,
-        args: @args,
+      context.registers[:inline_snippet][@to] = {
+        body: @body,
       }
       ''
     end
-
-    private
-
-    def snippet_id
-      @to[1, @to.size - 2]
-    end
-
-    def snippet_body
-      body = @body
-      body
-    end
   end
 end