Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-12 23:40:45 -07:00
Code Issues Packages Projects Releases Wiki Activity

fast-path simple if conditions: skip ExpressionsAndOperators scan for single conditions

Browse Source
This commit is contained in:
Tobi Lutke
2026-04-04 17:33:53 -07:00
committed by Chris Pak
parent 9e6f93a494
commit 01f33e96e8
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/tags/if.rb
+12
View File
@@ -85,7 +85,19 @@ module Liquid
Condition.parse_expression(parse_context, markup, safe: safe) Condition.parse_expression(parse_context, markup, safe: safe)
end end
# Fast path regex for simple conditions: "expr", "expr op expr" (no and/or)
SIMPLE_CONDITION = /\A\s*(#{QuotedFragment})\s*(?:([=!<>a-z_]+)\s*(#{QuotedFragment}))?\s*\z/o
def lax_parse(markup) def lax_parse(markup)
# Fast path: simple condition without and/or
if !markup.include?(' and ') && !markup.include?(' or ') && markup =~ SIMPLE_CONDITION
return Condition.new(
parse_expression(Regexp.last_match(1)),
Regexp.last_match(2),
Regexp.last_match(3) ? parse_expression(Regexp.last_match(3)) : nil,
)
end
expressions = markup.scan(ExpressionsAndOperators) expressions = markup.scan(ExpressionsAndOperators)
raise SyntaxError, options[:locale].t("errors.syntax.if") unless expressions.pop =~ Syntax raise SyntaxError, options[:locale].t("errors.syntax.if") unless expressions.pop =~ Syntax