From 00be1e4dd44e6a69d2c2ae1efeda6449fee48cc3 Mon Sep 17 00:00:00 2001 From: Dylan Thacker-Smith Date: Fri, 11 Dec 2020 14:13:23 -0500 Subject: [PATCH] Update inherited rubocop shopify style guide configuration --- ...ify-github-io-ruby-style-guide-rubocop-yml | 31 +++++++------------ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml b/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml index 6cb8e45a..e77a0434 100644 --- a/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml +++ b/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml @@ -1,5 +1,3 @@ -# Recommended rubocop version: ~> 0.78.0 - AllCops: Exclude: - 'db/schema.rb' @@ -78,13 +76,6 @@ Style/BlockDelimiters: - proc - it -Style/BracesAroundHashParameters: - EnforcedStyle: no_braces - SupportedStyles: - - braces - - no_braces - - context_dependent - Layout/CaseIndentation: EnforcedStyle: end SupportedStyles: @@ -204,6 +195,7 @@ Style/FrozenStringLiteralComment: SupportedStyles: - always - never + SafeAutoCorrect: true Style/GlobalVars: AllowedVariables: [] @@ -273,7 +265,7 @@ Style/MethodCallWithArgsParentheses: - raise - puts Exclude: - - Gemfile + - '**/Gemfile' Style/MethodDefParentheses: EnforcedStyle: require_parentheses @@ -586,6 +578,7 @@ Layout/BlockEndNewline: Style/CaseEquality: Enabled: true + AllowOnConstant: true Style/CharacterLiteral: Enabled: true @@ -668,6 +661,9 @@ Style/IfWithSemicolon: Style/IdenticalConditionalBranches: Enabled: true +Layout/IndentationStyle: + Enabled: true + Style/InfiniteLoop: Enabled: true @@ -680,7 +676,7 @@ Style/LineEndConcatenation: Style/MethodCallWithoutArgsParentheses: Enabled: true -Style/MethodMissingSuper: +Lint/MissingSuper: Enabled: true Style/MissingRespondToMissing: @@ -812,9 +808,6 @@ Layout/SpaceInsideRangeLiteral: Style/SymbolLiteral: Enabled: true -Layout/Tab: - Enabled: true - Layout/TrailingWhitespace: Enabled: true @@ -843,7 +836,7 @@ Style/ZeroLengthPredicate: Enabled: true Layout/HeredocIndentation: - EnforcedStyle: squiggly + Enabled: true Lint/AmbiguousOperator: Enabled: true @@ -881,9 +874,6 @@ Lint/EmptyEnsure: Lint/EmptyInterpolation: Enabled: true -Lint/EndInMethod: - Enabled: true - Lint/EnsureReturn: Enabled: true @@ -976,7 +966,7 @@ Lint/UselessAccessModifier: Lint/UselessAssignment: Enabled: true -Lint/UselessComparison: +Lint/BinaryOperatorWithIdenticalOperands: Enabled: true Lint/UselessElseWithoutRescue: @@ -1027,3 +1017,6 @@ Style/ModuleFunction: Lint/OrderedMagicComments: Enabled: true + +Lint/DeprecatedOpenSSLConstant: + Enabled: true