Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-20 11:20:41 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #519 from Shopify/remove-filter-method-blacklist

Browse Source 
Allow filters to redefine Object methods to make them invokable.
This commit is contained in:
Dylan Thacker-Smith
2015-02-04 18:09:51 -05:00
committed by Dylan Thacker-Smith
parent 95b340a7cf
commit 000d0c911b
5 changed files with 50 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/unit/strainer_unit_test.rb
+6 -8
View File
@@ -31,11 +31,11 @@ class StrainerUnitTest < Minitest::Test
def test_strainer_only_invokes_public_filter_methods
strainer = Strainer.create(nil)
assert_equal false, strainer.invokable?('__test__')
assert_equal false, strainer.invokable?('test')
assert_equal false, strainer.invokable?('instance_eval')
assert_equal false, strainer.invokable?('__send__')
assert_equal true, strainer.invokable?('size') # from the standard lib
assert_equal false, strainer.class.invokable?('__test__')
assert_equal false, strainer.class.invokable?('test')
assert_equal false, strainer.class.invokable?('instance_eval')
assert_equal false, strainer.class.invokable?('__send__')
assert_equal true, strainer.class.invokable?('size') # from the standard lib
end
def test_strainer_returns_nil_if_no_filter_method_found
@@ -63,9 +63,7 @@ class StrainerUnitTest < Minitest::Test
assert_kind_of Strainer, strainer
assert_kind_of a, strainer
assert_kind_of b, strainer
Strainer.class_variable_get(:@@filters).each do |m|
assert_kind_of m, strainer
end
assert_kind_of Liquid::StandardFilters, strainer
end
end # StrainerTest